Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the "max reconciles" for each controller to 25 #724

Merged
merged 1 commit into from
Oct 18, 2024
Merged

Conversation

EronWright
Copy link
Contributor

@EronWright EronWright commented Oct 18, 2024

Proposed changes

Use 25 by default to facilitate the blocking operations in the auto API, and support the MAX_CONCURRENT_RECONCILES environment variable.

Related issues (optional)

Closes #721

@EronWright EronWright requested a review from blampe October 18, 2024 17:14
@EronWright EronWright changed the base branch from master to v2 October 18, 2024 17:14
@EronWright EronWright added the impact/no-changelog-required This issue doesn't require a CHANGELOG update label Oct 18, 2024
@EronWright EronWright merged commit 542be71 into v2 Oct 18, 2024
2 checks passed
@EronWright EronWright deleted the issue-721 branch October 18, 2024 17:15
Copy link
Contributor

@blampe blampe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

MaxConcurrentReconciles: 25,
}
if s, ok := os.LookupEnv("MAX_CONCURRENT_RECONCILES"); ok {
controllerOpts.MaxConcurrentReconciles, _ = strconv.Atoi(s)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should probably panic if this doesn't parse, otherwise it'll be zero which I'm guessing would do... nothing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact/no-changelog-required This issue doesn't require a CHANGELOG update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants