Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade terraform provider rancher2 to v5.0.0 major #555

Merged
merged 2 commits into from
Sep 13, 2024
Merged

Upgrade terraform provider rancher2 to v5.0.0 major #555

merged 2 commits into from
Sep 13, 2024

Conversation

guineveresaenger
Copy link
Contributor

@guineveresaenger guineveresaenger commented Sep 12, 2024 •
edited
Loading

Fixes #547.

Confirming with upstream: there are lots of schema changes, but these removals reflect the upstream provider.

  • update version, add replaces, make tfgen
  • Generate SDK

@github-actions GitHub Actions
Copy link
Contributor

Does the PR have any schema changes?

Found 108 breaking changes:

Resources

  • "rancher2:index/cluster:Cluster":
    • inputs:
      • 🟡 "clusterMonitoringInput" missing
      • 🟡 "defaultPodSecurityPolicyTemplateId" missing
      • 🟡 "enableClusterAlerting" missing
      • 🟡 "enableClusterMonitoring" missing
    • properties:
      • 🟡 "clusterMonitoringInput" missing output "clusterMonitoringInput"
      • 🟡 "defaultPodSecurityPolicyTemplateId" missing output "defaultPodSecurityPolicyTemplateId"
      • 🟡 "enableClusterAlerting" missing output "enableClusterAlerting"
      • 🟡 "enableClusterMonitoring" missing output "enableClusterMonitoring"
  • 🔴 "rancher2:index/clusterAlertGroup:ClusterAlertGroup" missing
  • 🔴 "rancher2:index/clusterAlertRule:ClusterAlertRule" missing
  • "rancher2:index/clusterSync:ClusterSync":
    • inputs:
      • 🟡 "waitAlerting" missing
      • 🟡 "waitMonitoring" missing
    • properties:
      • 🟡 "waitAlerting" missing output "waitAlerting"
      • 🟡 "waitMonitoring" missing output "waitMonitoring"
  • "rancher2:index/clusterV2:ClusterV2":
    • 🟡 inputs: "defaultPodSecurityPolicyTemplateName" missing
    • 🟡 properties: "defaultPodSecurityPolicyTemplateName" missing output "defaultPodSecurityPolicyTemplateName"
  • 🔴 "rancher2:index/notifier:Notifier" missing
  • 🔴 "rancher2:index/podSecurityPolicyTemplate:PodSecurityPolicyTemplate" missing
  • "rancher2:index/project:Project":
    • inputs:
      • 🟡 "enableProjectMonitoring" missing
      • 🟡 "podSecurityPolicyTemplateId" missing
      • 🟡 "projectMonitoringInput" missing
    • properties:
      • 🟡 "enableProjectMonitoring" missing output "enableProjectMonitoring"
      • 🟡 "podSecurityPolicyTemplateId" missing output "podSecurityPolicyTemplateId"
      • 🟡 "projectMonitoringInput" missing output "projectMonitoringInput"
  • 🔴 "rancher2:index/projectAlertGroup:ProjectAlertGroup" missing
  • 🔴 "rancher2:index/projectAlertRule:ProjectAlertRule" missing

Functions

  • 🔴 "rancher2:index/getClusterAlertGroup:getClusterAlertGroup" missing
  • 🔴 "rancher2:index/getClusterAlertRule:getClusterAlertRule" missing
  • 🔴 "rancher2:index/getNotifier:getNotifier" missing
  • 🔴 "rancher2:index/getPodSecurityPolicyTemplate:getPodSecurityPolicyTemplate" missing
  • 🔴 "rancher2:index/getProjectAlertGroup:getProjectAlertGroup" missing
  • 🔴 "rancher2:index/getProjectAlertRule:getProjectAlertRule" missing

Types

  • 🔴 "rancher2:index/ClusterAlertGroupRecipient:ClusterAlertGroupRecipient" missing
  • 🔴 "rancher2:index/ClusterAlertRuleEventRule:ClusterAlertRuleEventRule" missing
  • 🔴 "rancher2:index/ClusterAlertRuleMetricRule:ClusterAlertRuleMetricRule" missing
  • 🔴 "rancher2:index/ClusterAlertRuleNodeRule:ClusterAlertRuleNodeRule" missing
  • 🔴 "rancher2:index/ClusterAlertRuleSystemServiceRule:ClusterAlertRuleSystemServiceRule" missing
  • 🔴 "rancher2:index/ClusterClusterMonitoringInput:ClusterClusterMonitoringInput" missing
  • 🟡 "rancher2:index/ClusterRkeConfigServicesKubeApi:ClusterRkeConfigServicesKubeApi": properties: "podSecurityPolicy" missing
  • "rancher2:index/ClusterTemplateTemplateRevisionClusterConfig:ClusterTemplateTemplateRevisionClusterConfig": properties:
    • 🟡 "defaultPodSecurityPolicyTemplateId" missing
    • 🟡 "enableClusterAlerting" missing
    • 🟡 "enableClusterMonitoring" missing
  • 🟡 "rancher2:index/ClusterTemplateTemplateRevisionClusterConfigRkeConfigServicesKubeApi:ClusterTemplateTemplateRevisionClusterConfigRkeConfigServicesKubeApi": properties: "podSecurityPolicy" missing
  • 🔴 "rancher2:index/NotifierDingtalkConfig:NotifierDingtalkConfig" missing
  • 🔴 "rancher2:index/NotifierMsteamsConfig:NotifierMsteamsConfig" missing
  • 🔴 "rancher2:index/NotifierPagerdutyConfig:NotifierPagerdutyConfig" missing
  • 🔴 "rancher2:index/NotifierSlackConfig:NotifierSlackConfig" missing
  • 🔴 "rancher2:index/NotifierSmtpConfig:NotifierSmtpConfig" missing
  • 🔴 "rancher2:index/NotifierWebhookConfig:NotifierWebhookConfig" missing
  • 🔴 "rancher2:index/NotifierWechatConfig:NotifierWechatConfig" missing
  • 🔴 "rancher2:index/PodSecurityPolicyTemplateAllowedCsiDriver:PodSecurityPolicyTemplateAllowedCsiDriver" missing
  • 🔴 "rancher2:index/PodSecurityPolicyTemplateAllowedFlexVolume:PodSecurityPolicyTemplateAllowedFlexVolume" missing
  • 🔴 "rancher2:index/PodSecurityPolicyTemplateAllowedHostPath:PodSecurityPolicyTemplateAllowedHostPath" missing
  • 🔴 "rancher2:index/PodSecurityPolicyTemplateFsGroup:PodSecurityPolicyTemplateFsGroup" missing
  • 🔴 "rancher2:index/PodSecurityPolicyTemplateFsGroupRange:PodSecurityPolicyTemplateFsGroupRange" missing
  • 🔴 "rancher2:index/PodSecurityPolicyTemplateHostPort:PodSecurityPolicyTemplateHostPort" missing
  • 🔴 "rancher2:index/PodSecurityPolicyTemplateRunAsGroup:PodSecurityPolicyTemplateRunAsGroup" missing
  • 🔴 "rancher2:index/PodSecurityPolicyTemplateRunAsGroupRange:PodSecurityPolicyTemplateRunAsGroupRange" missing
  • 🔴 "rancher2:index/PodSecurityPolicyTemplateRunAsUser:PodSecurityPolicyTemplateRunAsUser" missing
  • 🔴 "rancher2:index/PodSecurityPolicyTemplateRunAsUserRange:PodSecurityPolicyTemplateRunAsUserRange" missing
  • 🔴 "rancher2:index/PodSecurityPolicyTemplateRuntimeClass:PodSecurityPolicyTemplateRuntimeClass" missing
  • 🔴 "rancher2:index/PodSecurityPolicyTemplateSeLinux:PodSecurityPolicyTemplateSeLinux" missing
  • 🔴 "rancher2:index/PodSecurityPolicyTemplateSeLinuxSeLinuxOption:PodSecurityPolicyTemplateSeLinuxSeLinuxOption" missing
  • 🔴 "rancher2:index/PodSecurityPolicyTemplateSupplementalGroup:PodSecurityPolicyTemplateSupplementalGroup" missing
  • 🔴 "rancher2:index/PodSecurityPolicyTemplateSupplementalGroupRange:PodSecurityPolicyTemplateSupplementalGroupRange" missing
  • 🔴 "rancher2:index/ProjectAlertGroupRecipient:ProjectAlertGroupRecipient" missing
  • 🔴 "rancher2:index/ProjectAlertRuleMetricRule:ProjectAlertRuleMetricRule" missing
  • 🔴 "rancher2:index/ProjectAlertRulePodRule:ProjectAlertRulePodRule" missing
  • 🔴 "rancher2:index/ProjectAlertRuleWorkloadRule:ProjectAlertRuleWorkloadRule" missing
  • 🔴 "rancher2:index/ProjectProjectMonitoringInput:ProjectProjectMonitoringInput" missing
  • 🔴 "rancher2:index/getClusterAlertGroupRecipient:getClusterAlertGroupRecipient" missing
  • 🔴 "rancher2:index/getClusterAlertRuleEventRule:getClusterAlertRuleEventRule" missing
  • 🔴 "rancher2:index/getClusterAlertRuleMetricRule:getClusterAlertRuleMetricRule" missing
  • 🔴 "rancher2:index/getClusterAlertRuleNodeRule:getClusterAlertRuleNodeRule" missing
  • 🔴 "rancher2:index/getClusterAlertRuleSystemServiceRule:getClusterAlertRuleSystemServiceRule" missing
  • 🔴 "rancher2:index/getClusterClusterMonitoringInput:getClusterClusterMonitoringInput" missing
  • 🟡 "rancher2:index/getClusterRkeConfigServicesKubeApi:getClusterRkeConfigServicesKubeApi": properties: "podSecurityPolicy" missing
  • "rancher2:index/getClusterTemplateTemplateRevisionClusterConfig:getClusterTemplateTemplateRevisionClusterConfig":
    • properties:
      • 🟡 "defaultPodSecurityPolicyTemplateId" missing
      • 🟡 "enableClusterAlerting" missing
      • 🟡 "enableClusterMonitoring" missing
    • 🟢 required: "defaultPodSecurityPolicyTemplateId" property is no longer Required
  • 🟡 "rancher2:index/getClusterTemplateTemplateRevisionClusterConfigRkeConfigServicesKubeApi:getClusterTemplateTemplateRevisionClusterConfigRkeConfigServicesKubeApi": properties: "podSecurityPolicy" missing
  • 🔴 "rancher2:index/getNotifierDingtalkConfig:getNotifierDingtalkConfig" missing
  • 🔴 "rancher2:index/getNotifierMsteamsConfig:getNotifierMsteamsConfig" missing
  • 🔴 "rancher2:index/getNotifierPagerdutyConfig:getNotifierPagerdutyConfig" missing
  • 🔴 "rancher2:index/getNotifierSlackConfig:getNotifierSlackConfig" missing
  • 🔴 "rancher2:index/getNotifierSmtpConfig:getNotifierSmtpConfig" missing
  • 🔴 "rancher2:index/getNotifierWebhookConfig:getNotifierWebhookConfig" missing
  • 🔴 "rancher2:index/getNotifierWechatConfig:getNotifierWechatConfig" missing
  • 🔴 "rancher2:index/getPodSecurityPolicyTemplateAllowedCsiDriver:getPodSecurityPolicyTemplateAllowedCsiDriver" missing
  • 🔴 "rancher2:index/getPodSecurityPolicyTemplateAllowedFlexVolume:getPodSecurityPolicyTemplateAllowedFlexVolume" missing
  • 🔴 "rancher2:index/getPodSecurityPolicyTemplateAllowedHostPath:getPodSecurityPolicyTemplateAllowedHostPath" missing
  • 🔴 "rancher2:index/getPodSecurityPolicyTemplateFsGroup:getPodSecurityPolicyTemplateFsGroup" missing
  • 🔴 "rancher2:index/getPodSecurityPolicyTemplateFsGroupRange:getPodSecurityPolicyTemplateFsGroupRange" missing
  • 🔴 "rancher2:index/getPodSecurityPolicyTemplateHostPort:getPodSecurityPolicyTemplateHostPort" missing
  • 🔴 "rancher2:index/getPodSecurityPolicyTemplateRunAsGroup:getPodSecurityPolicyTemplateRunAsGroup" missing
  • 🔴 "rancher2:index/getPodSecurityPolicyTemplateRunAsGroupRange:getPodSecurityPolicyTemplateRunAsGroupRange" missing
  • 🔴 "rancher2:index/getPodSecurityPolicyTemplateRunAsUser:getPodSecurityPolicyTemplateRunAsUser" missing
  • 🔴 "rancher2:index/getPodSecurityPolicyTemplateRunAsUserRange:getPodSecurityPolicyTemplateRunAsUserRange" missing
  • 🔴 "rancher2:index/getPodSecurityPolicyTemplateRuntimeClass:getPodSecurityPolicyTemplateRuntimeClass" missing
  • 🔴 "rancher2:index/getPodSecurityPolicyTemplateSeLinux:getPodSecurityPolicyTemplateSeLinux" missing
  • 🔴 "rancher2:index/getPodSecurityPolicyTemplateSeLinuxSeLinuxOption:getPodSecurityPolicyTemplateSeLinuxSeLinuxOption" missing
  • 🔴 "rancher2:index/getPodSecurityPolicyTemplateSupplementalGroup:getPodSecurityPolicyTemplateSupplementalGroup" missing
  • 🔴 "rancher2:index/getPodSecurityPolicyTemplateSupplementalGroupRange:getPodSecurityPolicyTemplateSupplementalGroupRange" missing
  • 🔴 "rancher2:index/getProjectAlertGroupRecipient:getProjectAlertGroupRecipient" missing
  • 🔴 "rancher2:index/getProjectAlertRuleMetricRule:getProjectAlertRuleMetricRule" missing
  • 🔴 "rancher2:index/getProjectAlertRulePodRule:getProjectAlertRulePodRule" missing
  • 🔴 "rancher2:index/getProjectAlertRuleWorkloadRule:getProjectAlertRuleWorkloadRule" missing
    No new resources/functions.

Maintainer note: consult the runbook for dealing with any breaking changes.

@guineveresaenger guineveresaenger changed the title upgrade terraform provider rancher2 to v5.0.0 major Upgrade terraform provider rancher2 to v5.0.0 major Sep 12, 2024
@guineveresaenger guineveresaenger marked this pull request as draft September 12, 2024 23:00
@guineveresaenger guineveresaenger marked this pull request as ready for review September 12, 2024 23:06
@guineveresaenger guineveresaenger requested review from iwahbe and a team September 12, 2024 23:07
@guineveresaenger guineveresaenger merged commit d11cd63 into master Sep 13, 2024
24 checks passed
@guineveresaenger guineveresaenger deleted the upgrade-terraform-provider-rancher2-to-v5.0.0-major branch September 13, 2024 16:06
@iwahbe iwahbe mentioned this pull request Sep 16, 2024
Closed
@pulumi-bot
Copy link
Contributor

This PR has been shipped in release v7.0.0.

@pulumi-bot pulumi-bot mentioned this pull request Sep 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iwahbe iwahbe iwahbe approved these changes

Assignees

@guineveresaenger guineveresaenger

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade terraform-provider-rancher2 to v5.0.0
3 participants
@guineveresaenger @pulumi-bot @iwahbe