Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v5.16.0 errors on yarn install #321

Closed
AMKamel opened this issue Oct 17, 2023 · 1 comment · Fixed by #322
Closed

v5.16.0 errors on yarn install #321

AMKamel opened this issue Oct 17, 2023 · 1 comment · Fixed by #322
Assignees
Labels
kind/bug Some behavior is incorrect or out of spec p1 A bug severe enough to be the next item assigned to an engineer resolution/fixed This issue was fixed
Milestone

Comments

@AMKamel
Copy link

AMKamel commented Oct 17, 2023

What happened?

I have upgraded to version 5.16.0 and got an error after running yarn upgrade-interactive

Example

yarn upgrade interactive

then upgrade to 5.16.0 version

➤ YN0000: ┌ Link step
➤ YN0007: │ @pulumi/vault@npm:5.16.0 must be built because it never has been before or the last one failed
➤ YN0009: │ @pulumi/vault@npm:5.16.0 couldn't be built successfully (exit code 1, logs can be found here: /tmp/xfs-59412d6c/build.log)
cat /tmp/xfs-59412d6c/build.log                           
# This file contains the result of Yarn building a package (@pulumi/vault@npm:5.16.0)
# Script name: install

node:internal/modules/cjs/loader:1080
  throw err;
  ^

Error: Cannot find module '/home/abukamel/codebases/work/iac/pulumi/programs/deployment/node_modules/@pulumi/vault/scripts/install-pulumi-plugin.js'
    at Module._resolveFilename (node:internal/modules/cjs/loader:1077:15)
    at Module._load (node:internal/modules/cjs/loader:922:27)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:86:12)
    at node:internal/main/run_main_module:23:47 {
  code: 'MODULE_NOT_FOUND',
  requireStack: []
}

Node.js v18.18.0

Output of pulumi about

CLI          
Version      3.89.0
Go Version   go1.21.1
Go Compiler  gc

Plugins
NAME    VERSION
nodejs  unknown

Host     
OS       ubuntu
Version  22.04
Arch     x86_64

This project is written in nodejs: executable='/home/abukamel/.nvm/versions/node/v18.18.0/bin/node' version='v18.18.0'

Additional context

Downgrading to v5.15.1 resolved the issue

Contributing

Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

@AMKamel AMKamel added kind/bug Some behavior is incorrect or out of spec needs-triage Needs attention from the triage team labels Oct 17, 2023
@mikhailshilkov mikhailshilkov added p1 A bug severe enough to be the next item assigned to an engineer and removed needs-triage Needs attention from the triage team labels Oct 17, 2023
@mikhailshilkov mikhailshilkov added this to the 0.95 milestone Oct 17, 2023
@guineveresaenger guineveresaenger self-assigned this Oct 17, 2023
guineveresaenger added a commit that referenced this issue Oct 17, 2023
The version of pulumi-package-publisher used in the latest release does
not account for the old nodejs install scripts, that the version of the
bridge we are using still generates. Version 0.0.9 has a hotfix meant to
address an npm install failure that expects these scripts.

We can verify this works after merge to default branch, and then
installing `latest`. Then we can push a patch.

Read context here: pulumi/pulumi-github#377

Fixes #321.
@pulumi-bot pulumi-bot added the resolution/fixed This issue was fixed label Oct 17, 2023
@guineveresaenger
Copy link
Contributor

I verified that tip of master at npm install @pulumi/[email protected] works as expected.

Cutting a patch v5.16.1 now, please let us know if the issue persists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Some behavior is incorrect or out of spec p1 A bug severe enough to be the next item assigned to an engineer resolution/fixed This issue was fixed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants