-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vault Provider Args token
should not be mandatory
#509
Comments
Hey @arpanrec - thank you for reporting this issue. We'll take a look as soon as we can. |
Hi @arpanrec - I took a quick peek upstream and it appears from the schema that Can you tell us a bit more in which way this presents as a blocker to you? Does declaring |
Note that I opened hashicorp/terraform-provider-vault#2237 upstream. |
@guineveresaenger , as you can see in the code example above I have done exactly that, But I have never looked at the upstream source code of terraform-vault-provider. I just saw Terraform docs and I saw it's marked optional. I can see you have done all the research already hashicorp/terraform-provider-vault#2237 here. Thanks |
@arpanrec - All right, so I've gotten some more context here. First off, the current workaround for this issue is, as you discovered, passing an empty string to Upstream has made the choice to allow for the schema to say On our end, we do need to support this kind of behavior better, so I've filed pulumi/pulumi-terraform-bridge#1978 to follow up. I'm leaving this issue open and will close when the workaround is no longer necessary. Thanks again for the find! |
Yes, I agree, I should have checked the source code in Terraform vault provider first, as the conflict is in the source code vs terraform docs. my bad. Off-Topic: Any way loving pulumi in big terraform to pulumi rewrite in TS. Keep it up. |
What happened?
Vault Provider Args
token
should not be mandatory, as we have other authentication methods.in
node_modules/@pulumi/vault/provider.d.ts
Example
Output of
pulumi about
❯ pulumi about
CLI
Version 3.116.0
Go Version go1.22.2
Go Compiler gc
Host
OS arch
Version "rolling"
Arch x86_64
Backend
Name pulumi.com
URL https://app.pulumi.com
User Unknown
Organizations
Token type personal
Additional context
It is not mandatory in terraform vault provider.
https://registry.terraform.io/providers/hashicorp/vault/latest/docs#token
Contributing
Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).
The text was updated successfully, but these errors were encountered: