Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(PA-5654) Remove warnflags from rbconfig.rb on AIX #2386

Merged

Conversation

AriaXLi
Copy link
Contributor

@AriaXLi AriaXLi commented Aug 15, 2023

The validate_vendored_ruby.rb test is failing on AIX when trying to compile native extensions for the sqlite3 gem. The gcc version used in this test (gcc 5.2.0) does not recognize the warnflags used in rbconfig.rb. This is because a newer gcc (gcc 10) was used when when creating rbconfig.rb.

This commit removes the warnflags in rbconfig.rb on AIX.

The validate_vendored_ruby.rb test is failing on AIX when trying to compile
native extensions for the sqlite3 gem. The gcc version used in this test (gcc
5.2.0) does not recognize the `warnflags` used in rbconfig.rb. This is because
a newer gcc (gcc 10) was used when when creating rbconfig.rb.

This commit removes the `warnflags` in rbconfig.rb on AIX.
@AriaXLi AriaXLi requested a review from a team as a code owner August 15, 2023 00:25
@AriaXLi
Copy link
Contributor Author

AriaXLi commented Aug 15, 2023

I tested my changes locally to make sure the test passes now using these commands:

$ bundle exec beaker-hostgenerator redhat7-64m-aix72-POWERfa%7Bpackaging_platform=aix-7.2-power%7D --hypervisor abs --templates-only --disable-default-role
$ bundle exec rake ci:test:setup HOSTS=hosts.yaml SHA=7de9105be1c2823ca833cb28face1a615cdddc07
$ bundle exec beaker exec tests/validate_vendored_ruby.rb
...
tests/validate_vendored_ruby.rb passed in 193.82 seconds
      Test Suite: tests @ 2023-08-14 16:54:47 -0700

      - Host Configuration Summary -


              - Test Case Summary for suite 'tests' -
       Total Suite Time: 193.82 seconds
      Average Test Time: 193.82 seconds
              Attempted: 1
                 Passed: 1
                 Failed: 0
                Errored: 0
                Skipped: 0
                Pending: 0
                  Total: 1

@joshcooper joshcooper merged commit 75cd90a into puppetlabs:main Aug 15, 2023
@AriaXLi AriaXLi deleted the PA-5654/validate_vendored_ruby_aix branch August 15, 2023 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants