Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] debian 11/ubuntu 22.04 need to handle apt-source differently #884

Open
vegaaz opened this issue Jan 2, 2023 · 5 comments · May be fixed by #885 or #965
Open

[Bug] debian 11/ubuntu 22.04 need to handle apt-source differently #884

vegaaz opened this issue Jan 2, 2023 · 5 comments · May be fixed by #885 or #965
Labels
community

Comments

@vegaaz
Copy link

vegaaz commented Jan 2, 2023

Since Ubuntu 22.04 / Debian 11 apt-key is deprecated. Storing gpg-keys in /etc/apt/trusted.gpg (default behavior) is now producing warnings.
Also it is not longer recommended to get the gpg-keys via keyserver for security purposes.
The recommended way is to provide the gpg-key in /etc/apt/keyrings/KEY.gpg and add '[ signed-by = PATH ]' to the docker.list-file.

The puppetlabs/apt-Module has already implemented the new way of key handling via #991.
In my opinion the docker::repos class has to handle releases above Ubuntu 22.04 and Debian 11 different.
@vegaaz vegaaz changed the title [Bug] docker-apt-source [Bug] debian 11/ubuntu 22.04 need to handle apt-source differently Jan 2, 2023
@vegaaz vegaaz linked a pull request Jan 2, 2023 that will close this issue
Open
@maxdwit
Copy link

maxdwit commented Feb 28, 2023

Would like to have this merged, please.

@xRoyalz
Copy link

xRoyalz commented Jul 3, 2023

Is this going to be merged anytime soon?

@vegaaz
Copy link
Author

vegaaz commented Jul 4, 2023

The code by itself is done but testing/ linting is failing at the moment.
Since I am no longer working with Puppet, I‘m missing the linting/testing tools.

@xRoyalz please feel free to contribute :)

@waldman
Copy link

waldman commented Jul 5, 2024 •
edited
Loading

I have exactly zero time and interest on opening a proper pull request but I like to help people sooo...

I fixed this bug by commenting out the section below:
https://github.com/puppetlabs/puppetlabs-docker/blob/main/manifests/repos.pp#L26-L34

Replacing it by

        apt::source { 'docker':
          comment  => 'Docker',
          location => 'https://download.docker.com/linux/ubuntu',
          repos    => 'stable',
          notify   => Exec['apt_update'],
          key      => {
            'name'   => 'docker-archive-keyring.asc',
            'source' => 'https://download.docker.com/linux/ubuntu/gpg',
          },
        }

YMMV tho! xD

@kenyon
Copy link
Contributor

kenyon commented Jul 5, 2024

#965 fixes this.

@kenyon kenyon linked a pull request Jul 5, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
community
Projects
None yet
Milestone
No milestone
6 participants
@kenyon @waldman @maxdwit @xRoyalz @vegaaz @ia-content