Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Splitting limo2.31.py into multiple files #11

Open
aaron97neu opened this issue Nov 9, 2018 · 4 comments
Open

Splitting limo2.31.py into multiple files #11

aaron97neu opened this issue Nov 9, 2018 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@aaron97neu
Copy link
Member

Related to #10

Limo2.31.py contains almost 3000 lines of python code. In addition to being a security risk (The server gives access to all functions defined in this file to the user - including internal functions), this is unwieldy and bad practice. These python functions should be split into multiple files, at the very least public and private (internal) functions.

See XINU for an example of good organization of a large project

@aaron97neu aaron97neu added the enhancement New feature or request label Nov 9, 2018
@NQureshi850
Copy link
Collaborator

il see if i can handle this issue, it's gonna take a while since this file is massive and organizing it into multiple files is going to take some time.

@aaron97neu
Copy link
Member Author

We should also consider another file for stucts, classes, and other objects as well

@NQureshi850
Copy link
Collaborator

I feel like for now, we should seperate the functions and see if we can make objects and structs out of them. Its easier to see once they are separated and grouped

@aaron97neu
Copy link
Member Author

Note - All functions that are provided to the user will be marked in the code with the comment
# User Function
This should allow us to find these function quickly when we eventually split the file

Currently in CommutersAsObjects branch but should be merged into dev by May 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants