Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cobs_encode() name clashing at runtime #418

Open
Richard-Stump opened this issue Sep 21, 2022 · 0 comments
Open

cobs_encode() name clashing at runtime #418

Richard-Stump opened this issue Sep 21, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@Richard-Stump
Copy link
Contributor

A user on VTOW discovered that implementing his own cobs_encode function caused his program to crash at runtime, with the stack trace showing only the address 0x3805820.

I believe the issue is that our implementation of cobs_encode in src/common/cobs.c is a public symbol, so when the hot and cold packages link at runtime, the links their cobs_encode calls to our implementation. The main thing is that the symbols for our implementation should be stripped.

This should be investigated further to see if cobs_encode_measure also causes this issue, and if any other functions in the kernel cause this issue.

@WillXuCodes WillXuCodes changed the title PROS 3.7.2: cobs_encode() name clashing at runtime cobs_encode() name clashing at runtime Jan 12, 2023
@WillXuCodes WillXuCodes added the bug Something isn't working label Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants