Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More reliable way to determine UI has been repainted #230

Closed
romanofski opened this issue Dec 14, 2018 · 3 comments
Closed

More reliable way to determine UI has been repainted #230

romanofski opened this issue Dec 14, 2018 · 3 comments
Labels

Comments

@romanofski
Copy link
Member

The user acceptance tests are currently subject to timing problems (see #228 as an example). The reason for this is polling the terminal output for a specific sub string to appear. This is unfortunately error prone, because the author of the test may not be aware that his sub string is part of subsequent views. The test steps pass until a subsequent test step times out. This can be very confusing and provides no room to execute tests faster, since the potential for ending up with more brittle tests is high.

Therefore the motivation is high, to find a more reliable way to determine if the terminal pane has changed.

Describe the solution you'd like
A more reliable way to determine the terminal pane has been repainted.

Describe alternatives you've considered
The current implementation is error prone, since it polls for changes in the terminal output. No other alternatives have been investigated so far.

@romanofski
Copy link
Member Author

This may still involve waiting for characters to appear or not, but tmux (like GNU screen) allows to monitor for changes in the terminal output. Perhaps we could investigate that in order to check more reliably that the UI has changed.

@romanofski romanofski added this to the Future Feature milestone Jan 12, 2019
@romanofski
Copy link
Member Author

@frasertweedale made a good point when discussing this, that the monitor itself could trigger not only when the UI is getting repainted, but any activity. So when looking into this we need to check if any event activity in purebred could lead to falsely noticing a repaint.

@romanofski
Copy link
Member Author

Closed in favour of purebred-mua/tasty-tmux#7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant