Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compare Substring condition against textual interface? #19

Open
romanofski opened this issue May 19, 2020 · 2 comments
Open

Compare Substring condition against textual interface? #19

romanofski opened this issue May 19, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@romanofski
Copy link
Member

Is your feature request related to a problem? Please describe.
After writing a few acceptance tests now, I wonder if it would be more useful to use the Substring conditions only comparing against the textual representation of the output.

Describe the solution you'd like
For example, the raw output is:

\ESC[36minbox\ESC[34m \ESC[36marchive\ESC[34m WIP Refactor

so the substring would only compare against strings without control sequences:

inbox archive WIP Refactor

The regexes compare against the raw output.

What I'm not so certain about is, whether that feels as natural as it has occurred to me or whether it should be a different constructor.

Describe alternatives you've considered
None

Additional context
None

@romanofski romanofski added the enhancement New feature or request label May 19, 2020
@frasertweedale
Copy link
Member

We'd have to parse the ANSI and ignore the sequences. Feels more like an additional constructor arg to specify whether we ignore escape sequences or not... or maybe contramap or something...

@romanofski
Copy link
Member Author

Hm.. that is true... I haven't thought that far. Will have to check what contramap does ..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants