Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Reference API token from a kubernetes secret object #172

Open
yuha0 opened this issue Feb 13, 2020 · 3 comments
Open

[Feature Request] Reference API token from a kubernetes secret object #172

yuha0 opened this issue Feb 13, 2020 · 3 comments
Assignees
Labels
💡 enhancement New feature or request ❔ question Further information is requested

Comments

@yuha0
Copy link
Contributor

yuha0 commented Feb 13, 2020

Currently, the API token is specified as a string literal in PSOPlugin object in purestorage.com/v1.

Since we check in all cluster objects in a git repository, this would mean that we have to expose the token to everyone who has read permission to the repository. This is not very secure.

Kubernetes secret is designed for managing sensitive information, and there are many options to allow us to safely version control secrets in git in encrypted form.

Can we allow the token to be referenced as a, for example, v1.SecretKeySelector?

@sdodsley
Copy link
Collaborator

sdodsley commented Apr 2, 2020

@caryli-ps can we look into this?

@sdodsley sdodsley added 💡 enhancement New feature or request ❔ question Further information is requested labels Apr 2, 2020
@TJM
Copy link

TJM commented Sep 10, 2020

This just came up for us as well, we noticed that there was no way to get the API Token from a secret... It would require some restructuring, probably :(

@sdodsley
Copy link
Collaborator

@TJM I believe we now hold these API tokens in a secret but are not held in a secret that can be accessed by the Helm chart. This is still an open RFE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💡 enhancement New feature or request ❔ question Further information is requested
Projects
None yet
Development

No branches or pull requests

4 participants