New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

typing extensions is a dependency #2680

Open

pfps opened this issue Nov 14, 2024 · 3 comments

Labels

bug

Collaborator

pfps commented Nov 14, 2024

@MattHag Is this in the dependencies?

pfps added the bug label

Collaborator

MattHag commented Nov 14, 2024 •

edited

Loading

No, where would you need that? Python 3.8?

Collaborator Author

pfps commented Nov 14, 2024

I think that now lots of the Solaar files import typing_extensions.

Collaborator

MattHag commented Nov 14, 2024 •

edited

Loading

Oh, I've seen we have it as test dependency. I am not sure, if we need it as default dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment