Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STY: Move _repr_mimebundle_ #2978

Merged
merged 2 commits into from
Dec 2, 2024
Merged

Conversation

j-t-1
Copy link
Contributor

@j-t-1 j-t-1 commented Dec 2, 2024

Put as the last member of PdfWriter, as is different functionality to the other methods.

Put as the last member of PdfWriter, as is different functionality to the other methods.
Copy link

codecov bot commented Dec 2, 2024

Codecov Report

Attention: Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.

Project coverage is 96.36%. Comparing base (6d8a18a) to head (ba4ddb7).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
pypdf/_writer.py 77.77% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2978      +/-   ##
==========================================
- Coverage   96.36%   96.36%   -0.01%     
==========================================
  Files          52       52              
  Lines        8751     8749       -2     
  Branches     1591     1591              
==========================================
- Hits         8433     8431       -2     
  Misses        190      190              
  Partials      128      128              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Put as the last member of PdfWriter, as is different functionality to the other methods.
@stefan6419846 stefan6419846 merged commit fa1838c into py-pdf:main Dec 2, 2024
14 of 16 checks passed
@j-t-1 j-t-1 deleted the _repr_mimebundle_ branch December 2, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants