Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

falsify_graph uses np.math which does not exist #1268

Open
samiislam opened this issue Oct 27, 2024 · 2 comments
Open

falsify_graph uses np.math which does not exist #1268

samiislam opened this issue Oct 27, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@samiislam
Copy link

Describe the bug
On line 935

self.max_perms = np.math.factorial(self.causal_graph.number_of_nodes()) - int(self.exclude_original_order)

the method falsify_graph uses np.math which does not work.

Steps to reproduce the behavior

  1. Use falsify_graph in some code with valid parameters
  2. Errors out: AttributeError: module 'numpy' has no attribute 'math'

Expected behavior
falsify_graph returns without error

Version information:

  • DoWhy version 0.11.1
@samiislam samiislam added the bug Something isn't working label Oct 27, 2024
@bloebp
Copy link
Member

bloebp commented Oct 28, 2024

Hey, can you check which numpy version you have? That might be outdated.

@bloebp
Copy link
Member

bloebp commented Oct 28, 2024

Regardless, addressed it here: #1273

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants