fix(SlidingWindowFeature): fix PNG render with one feature #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`plt.subplots()` when called without explicitly setting the `squeeze` argument to False will try to squeeze out extra dimensions from the returned `axes` ndarray. Currently the code relies on this behaviour to get a 1-dimensional array when we pass in a hardcoded value of 1 for `ncols`, but does not count on this squeezing out *all* dimensions and returning a single `Axes` object when the (non-hardcoded) `nrows` is also 1. To fix this we set the `squeeze` argument to False and manually call `.flatten()` on the returned ndarray, to ensure we always get an exactly 1D array of Axes out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
plt.subplots()when called without explicitly setting thesqueezeargument to False will try to squeeze out extra dimensions from the returnedaxesndarray. Currently the code relies on this behaviour to get a 1-dimensional array when we pass in a hardcoded value of 1 forncols, but does not count on this squeezing out all dimensions and returning a singleAxesobject when the (non-hardcoded)nrowsis also 1.To fix this we set the
squeezeargument to False and manually call.flatten()on the returned ndarray, to ensure we always get an exactly 1D array of Axes out.