Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend pybamm.ParameterValues.create_from_bpx() to automate initial concentrations for blended electrodes #4338

Open
ejfdickinson opened this issue Aug 13, 2024 · 4 comments
Labels

Comments

@ejfdickinson
Copy link

Description

Calling pybamm.ParameterValues.create_from_bpx() with a BPX file containing a blended electrode returns a warning as follows:

Initial concentrations cannot be set using stoichiometry limits for blend electrodes. Please set the initial concentrations manually.

The method could automate this calculation by solving the equations specified in the BPX standard.

Motivation

No response

Possible Implementation

No response

Additional context

No response

@rtimms
Copy link
Contributor

rtimms commented Aug 13, 2024

Tagging #2682 as related. Currently the electrode state of health models in pybamm don't support blended electrodes.

@ejfdickinson
Copy link
Author

@rtimms Off-topic I know, but for this reason I find it odd that calc_esoh=True is the default in pybamm.Simulation.solve().

@rtimms
Copy link
Contributor

rtimms commented Aug 15, 2024

Yes, this is simply because calc_esoh predates blended electrodes. I’m open to changing this.

@valentinsulzer
Copy link
Member

The proper fix, which we are planning to do, is to do "just in time" calculations of esoh values only when they are requested

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants