Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add applied current functionality to EIS methods #478

Open
BradyPlanden opened this issue Aug 28, 2024 · 3 comments
Open

Add applied current functionality to EIS methods #478

BradyPlanden opened this issue Aug 28, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@BradyPlanden
Copy link
Member

Feature description

First discussed in #417, this issue is to add applied current functionality to the EIS forward model.

Motivation

The ability to incorporate applied current in the frequency domain impedance predictions enables non-stationary EIS methods for improvements in parameter inference.

Possible implementation

No response

Additional context

No response

@BradyPlanden BradyPlanden added the enhancement New feature or request label Aug 28, 2024
@rtimms
Copy link

rtimms commented Sep 2, 2024

I don't have the full context here, but is the forward simulation part of this something that can live in the EIS package? I'm conscious that integrating code directly in PyBOP and also developing pybamm-eis might lead to duplicated work or incompatibilities down the line.

@BradyPlanden
Copy link
Member Author

Hi @rtimms, I generally agree. This issue can probably be moved to pbeis, with PyBOP implementing the changes afterwards. Due to the way we build the forward model, I think we would need to refactor the underlying BaseModel to work directly with pbeis. Alternatively, we could look at building pbeis so that the API can be used by both PyBOP and casual users. At the moment I've implemented the pbeis method directly into PyBOP's BaseModel class, but in the future this could be rethought and updated.

@rtimms
Copy link

rtimms commented Sep 9, 2024

We could also just put the EISSimulation straight into pybamm and get rid of pbeis. Not sure of the the way PyBOP uses the model and sim, but having the EIS in pybamm would simplify things and avoid conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants