Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lower minimum requirements for Main datasets and Dimensions #57

Open
ssomnath opened this issue Oct 26, 2020 · 0 comments
Open

Lower minimum requirements for Main datasets and Dimensions #57

ssomnath opened this issue Oct 26, 2020 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@ssomnath
Copy link
Member

Lower the requirements for Dimension objects to have names, units, etc. Allow these to be keyword arguments?

Lower required arguments in write_main_dataset() to just:

  • h5_parent_group,
  • main_data - 2D dataset
  • pos_dims
  • spec_dims

The same checks should be reflected in check_if_main and other validation functions in hdf_utils

Unit tests should be changed accordingly as well
@ssomnath ssomnath added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ssomnath