Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with datasets without N-dimensional form #8

Open
ssomnath opened this issue Nov 16, 2018 · 1 comment
Open

Compatibility with datasets without N-dimensional form #8

ssomnath opened this issue Nov 16, 2018 · 1 comment
Labels
enhancement New feature or request

Comments

@ssomnath
Copy link
Member

Test all applicable functions with:

  1. Incomplete measurements (position axis)
  2. Sparse sampling (position axis)
  3. BEPS relaxation - dummy spectroscopic dimension

Thinking about guiding the self-explanatory handling of such datasets. Perhaps add attributes to the HDF5 file letting the code know how to handle the special case datasets.

One suggestion - add the following attributes to the ancillary datasets:

  1. dependent_dimensions : ['Field'] - this will handle dummy spectroscopic dimensions
  2. incomplete_dimensions : ['X', 'Y'] - this will handle both sparse sampling and incomplete measurements

Upon noticing either of these attributes, functions such as reshape_to_n_dims() would ignore all dimensions in dependent_dimensions when reshaping and collapse all dimensions in incomplete_dimensions to a single dimension in a numpy / Dask array

@ssomnath ssomnath added the enhancement New feature or request label Jun 6, 2019
@ssomnath
Copy link
Member Author

E.g. - in FORC BEPS SPM - DC_Offset indices never get reset since values are NOT the same per FORC cycle. Pycroscopy's BELoopFitter works around this issue by working entirely on the 2D dataset rather than reshaping to N-dimensions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant