Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nested models #86

Open
wpeterw opened this issue Dec 11, 2023 · 5 comments · May be fixed by #140
Open

Nested models #86

wpeterw opened this issue Dec 11, 2023 · 5 comments · May be fixed by #140
Milestone
v0.7.0

Comments

@wpeterw
Copy link

wpeterw commented Dec 11, 2023 •
edited
Loading

I have a model like this (code below), how do I access for instance the name in TeamModel ?

This does not work:

columns=[
    DisplayLookup(field="position"),
    DisplayLookup(field="team.name"),


class TeamModel(BaseModel):
    id: int
    name: str
    shortName: str
    tla: str
    crest: str

class Standing(BaseModel):
    position: Optional[int] = None
    team: Dict[str, str|int]
    playedGames: Optional[int] = None
    form: Any
    won: Optional[int] = None
    draw: Optional[int] = None
    lost: Optional[int] = None
    points: Optional[int] = None
@samuelcolvin
Copy link
Member

You mean in a table?

I think that's not yet supported.

@wpeterw
Copy link
Author

wpeterw commented Dec 11, 2023

yes, in a table, my data has nested objects.

@Dejiah
Copy link
Contributor

Dejiah commented Dec 11, 2023 •
edited
Loading

I think we could support that by using something like lodash.get (https://lodash.com/docs/4.17.15#get) in the frontend.

This way the backend can define any nested path to the data in the backend (e.g. teams.name or even array indexing like teams[0].names[1]) and the frontend tries to get the given path from the object.

Not sure if performance might be an issue here as we would do this for every cell. Though, I would assume that lodash's implementation is already quite optimized.

Would be happy to contribute a PR for this if you agree

@Dejiah Dejiah linked a pull request Dec 30, 2023 that will close this issue
Open
@hillstub
Copy link

hillstub commented Feb 3, 2024

One work-around could be to create a custom TeamRow model with non-nested fields that you want to display.

@MMartin09
Copy link

@hillstub Could you maybe provide a sample code? I am currently facing the same problem.

@sydney-runkle sydney-runkle added this to the v2.6.0 milestone Apr 19, 2024
@sydney-runkle sydney-runkle modified the milestones: v0.6.0, v0.7.0 May 2, 2024
@jimkring jimkring mentioned this issue Jun 1, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.7.0
Development

Successfully merging a pull request may close this issue.

Adds support for nested models and array elements in DisplayLookup Dejiah/FastUI
6 participants
@samuelcolvin @hillstub @wpeterw @MMartin09 @Dejiah @sydney-runkle