Vendor distutils stubs #4691
Draft
Vendor distutils stubs #4691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avasam
commented
Oct 17, 2024
Comment on lines
+206
to
+209
| # TODO: Include distutils stubs with package once we're confident in them | ||
| # "typings/distutils-stubs", |
There was a problem hiding this comment.
We don't need to ship anything as long as typeshed provides stubs for setuptools/_distutils. We can synchronize once ready.
As I mentioned in the issue, there's also always the option to ship it as a different package (in which case it could live completely separately from setuptools and pypa/distutils)
Avasam
commented
Oct 17, 2024
Comment on lines
+21
to
+22
| # Use our custom stubs for distutils | ||
| mypy_path = $MYPY_CONFIG_FILE_DIR/typings |
There was a problem hiding this comment.
I used pyright's default of typings so that I didn't have to configure it there. But that folder name can be arbitrary.
Avasam
force-pushed
the
vendor-distutils-stubs
branch
2 times, most recently
from
b1fec5c to
7ea98d5
Compare
Avasam
force-pushed
the
vendor-distutils-stubs
branch
2 times, most recently
from
98e4484 to
c440538
Compare
2 tasks
Avasam
force-pushed
the
vendor-distutils-stubs
branch
from
c440538 to
3dd8b4e
Compare
2 tasks
Avasam
force-pushed
the
vendor-distutils-stubs
branch
2 times, most recently
from
c01d02b to
53ed329
Compare
Avasam
force-pushed
the
vendor-distutils-stubs
branch
from
53ed329 to
20bda1b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Note: Please consider #4704 as an alternative !
See commit history. Basically I copied
stdlib/distutilsfrom typeshed, then appliedstubs/setuptools/_distutilsfrom typeshed on top.The following "fixups" have been brought back into typeshed and pypa/distutils, if you want we could wait for them to be merged and then I can rebase my changes here so reduce the amount of changes in my "fixups" commit:
I think these could go directly in https://github.com/pypa/distutils, vendoring them back into setuptools using the already existing process, to make it possibly easier to keep stubs and implementation in sync. But increasing the charge of pypa/distutils contributors. Do note it has to exist in a folder named
distutilsordistutils-stubs, preferably by itself.Closes #4689
Pull Request Checklist
newsfragments/. (no public facing changes as long as they're not published)(See documentation for details)