Empty tuple instead of None for PlatformInfo version properties fallthrough #4754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…workVersion64`` properties of ``setuptools.msvc.PlatformInfo`` to return an empty `tuple` instead of `None` as a fallthrough case
Avasam
force-pushed
the
empty-tuple-instead-of-None-PlatformInfo-properties
branch
from
5767ad6 to
2b471c2
Compare
abravalheri
reviewed
Nov 20, 2024
|
Thank you |
Avasam
deleted the
empty-tuple-instead-of-None-PlatformInfo-properties
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changed the
WindowsSdkVersion,FrameworkVersion32andFrameworkVersion64properties ofsetuptools.msvc.PlatformInfoto return an emptytupleinstead ofNoneas a fallthrough case.This also better matches the existing documentation which does not mention returning
None.In setuptools these are always used directly in iterations without ever checking for
Noneor truthyness.Fixes for #4744
Pull Request Checklist
newsfragments/.(See documentation for details)