-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Follow PEP 503's normalisation for dist-info folder name and wheel name #440
Comments
This has been discussed at length over at #411. |
I have some local code to address this, but I need to ensure that it can also work with wheels generated by older versions of |
The discussion on discourse was - at least as I understood it - about what to do for distribution names in wheel filenames. The agreement is to move towards similar normalisation rules everywhere, so not just |
Sure, but there are potential issues which may come up when the same project is packaged by a newer version of |
I agree with @agronholm - the discussion over on Discourse hasn't yet really addressed transition questions like this (as far as I can recall). I'm not sure what is needed here (maybe it's just something simple like "all tools must be prepared to read non-normalised filenames, which may come from older versions of tools, but must always write normalised forms") but I think we should get consensus so that (a) all tools are behaving the same, and (b) the agreed behaviour gets documented somewhere. |
In the spec, the name normalisation based on PEP 503 is a 'should' and we've said that "tools consuming wheels must be prepared to accept Admittedly there wasn't much discussion about this, but it seems fairly self evident: we've got a rule for how to consistently generate new wheel filenames, but we can't change all the ones already made, so you can't assume that all wheels will have a normalised filename. |
I'm closing this as I'm now working on a proper API in pypa/packaging#805. |
See https://discuss.python.org/t/revisiting-distribution-name-normalization/12348/ for the long form discussion.
Basically,
wheel
-generated wheels do not canonicalise name of the dist-info folder to remove.
from the name of the folder. This means that packages generated withwheel
can havepackage.name-1.0.0.dist-info
instead ofpackage_name-1.0.0.dist-info
.The text was updated successfully, but these errors were encountered: