New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revisit linting `noqa`s #59

Open

jGaboardi opened this issue Jul 10, 2024 · 0 comments

Assignees

Labels

Member

jGaboardi commented Jul 10, 2024

revisit linting noqas

spglm/spglm/glm.py

Line 343 in 4d435f7

model = self.model # noqa F841 - `model` never used
spglm/spglm/base.py

Line 309 in 4d435f7

dot_fun = nan_dot # noqa F821 - `nan_dot` not defined - should remove
spglm/spglm/utils.py

Line 23 in 4d435f7

string_types = basestring # noqa F821 - `basestring` not defined - should remove
spglm/spglm/varfuncs.py

Line 120 in 4d435f7

from statsmodels.tools.numdiff import approx_fprime_cs # noqa F401

xref #37

The text was updated successfully, but these errors were encountered:

jGaboardi added the maintenance label

jGaboardi assigned TaylorOshan and jGaboardi

jGaboardi mentioned this issue

code health -- tighten up linting & formatting #60

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment