Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix to profile plot (issue #204) #206

Merged
merged 1 commit into from
Oct 18, 2023
Merged

Fix to profile plot (issue #204) #206

merged 1 commit into from
Oct 18, 2023

Conversation

everettsp
Copy link
Contributor

@everettsp everettsp commented Oct 17, 2023 •
edited by aerispaha
Loading

Created fix for absolute offset values for when offset option is set to 'ELEVATION'

Closes #204

@everettsp
Update profiler.py
7708d30 
added fix for 'ELEVATION' offset option
@everettsp everettsp changed the title Update profiler.py Fix to profile plot (issue #204) Oct 17, 2023
@bemcdonnell
Copy link
Member

@everettsp nice work!

bemcdonnell
bemcdonnell approved these changes Oct 17, 2023
View reviewed changes
Copy link
Member

@bemcdonnell bemcdonnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aerispaha - you get final say!

@aerispaha
Copy link
Member

@everettsp thanks for this contribution! Looks good to me.

I'll get this into the next release asap.

@aerispaha aerispaha merged commit 6228427 into pyswmm:master Oct 18, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bemcdonnell bemcdonnell bemcdonnell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Negative offset elevations handled incorrectly in profile plot
3 participants
@everettsp @bemcdonnell @aerispaha