Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model summary property and RPT warning function (#154) #208

Merged
merged 2 commits into from
Nov 22, 2023

Conversation

everettsp
Copy link
Contributor

  • Created summarize_model function and _summary model property. The summarize_model() function can very easily be expanded to include more fields. This could maybe be changed to a function in the future to add the option of a more detailed summary
  • Created rpt_warnings function to read warnings from the head of the RPT file. The function requires a valid RPT file, but the run itself doesn't need to be successful. For warnings beyond those included in the RPT file, looks like drop_invalid_model_elements() currently provides some geometry warnings.

@aerispaha
Copy link
Member

@everettsp thanks for this contribution! I'd like to add some unit tests and a bit of documentation for this, but we can capture that in a separate issue.

@aerispaha aerispaha merged commit 0c52df7 into pyswmm:master Nov 22, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants