Passing single label to .loc rather than list of labels. Change deprecated delim_whitespace=True to sep=r'\s+' #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed depreciated delim_whitespace=True to sep=r'\s+'. Changed '\s+' to r'\s+'
|
@dirwin5, are these changes friendly with pandas<2? When it comes to major upgrades in dependencies, we are always very careful and strategic as to not force everyone to upgrade straight-away. We can always do a quick test on that with the requirements file. |
|
Hi @bemcdonnell, I believe they won't break pandas<2. I ran the all the tests with pandas 1.4.0 and numpy 1.21.0 and they all passed. |
|
@dirwin5 thanks for this! Just ran tests with Pandas > 2 and all seems fine. I'm going to approve and merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing single label to .loc rather than list of labels to return series rather than dataframe. This avoids FutureWarning: calling float on single element series and FutureWarning: Series.getitem treating keys as positions is deprecated.
Changed deprecated
delim_whitespace=Truetosep=r'\s+'.Changed
'\s+'tor'\s+'to remove invalid escape sequence '\s' warning.