Api refactor #14
Merged
Api refactor #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
m30m
commented
Feb 6, 2024
m30m
commented
- v1 prefix for all paths
- Use rest style paths
- Make all endpoints return json
- Better internal naming of structures
- Add versioning to opportunity params
jayantk
approved these changes
Feb 6, 2024
| "/v1/liquidation/submit_opportunity", | ||
| post(liquidation::submit_opportunity), | ||
| "/v1/liquidation/opportunity", | ||
| post(liquidation::post_opportunity), |
There was a problem hiding this comment.
this creates a new opportunity? If so, I think it should be a POST to /v1/liquidation/opportunities to match the usual REST conventions.
auction-server/src/api.rs
Outdated
| ) | ||
| .route("/v1/liquidation/bid", post(liquidation::post_bid)) |
There was a problem hiding this comment.
I think this should be POST /v1/liquidation/opportunities/<opportunity uuid>/bids
auction-server/src/api.rs
Outdated
| "/liquidation/submit_opportunity", | ||
| post(marketplace::submit_opportunity), | ||
| ) | ||
| .route("/v1/bid", post(bid::bid)) |
anihamde
reviewed
Feb 7, 2024
per_sdk/utils/endpoints.py
Outdated
| @@ -1,12 +1,7 @@ | |||
| LIQUIDATION_SERVER_ENDPOINT = "http://localhost:9000" | |||
| LIQUIDATION_SERVER_ENDPOINT = "http://localhost:9000/v1" | |||
| AUCTION_SERVER_ENDPOINT = "http://localhost:9000/bid" | |||
There was a problem hiding this comment.
i think we don't use this anymore?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.