Add express relay rust client #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danimhr
force-pushed
the
feat/rust-sdk
branch
from
aa6a452 to
af6d342
Compare
danimhr
force-pushed
the
feat/rust-sdk
branch
from
0e66242 to
de939a9
Compare
danimhr
force-pushed
the
feat/rust-sdk
branch
from
cfada1c to
de9d8dd
Compare
danimhr
changed the title
m30m
reviewed
Dec 14, 2024
| @@ -71,7 +72,10 @@ pub mod nullable_datetime { | |||
| S: Serializer, | |||
| { | |||
| match b { | |||
| Some(b) => s.serialize_str(b.to_string().as_str()), | |||
| Some(b) => { | |||
| let formatted = b.format(&Rfc3339).map_err(ser::Error::custom)?; | |||
There was a problem hiding this comment.
can you add some comment on why this is needed?
There was a problem hiding this comment.
what I meant was what is the difference of this and the previous logic we used
danimhr
force-pushed
the
feat/rust-sdk
branch
from
17cff85 to
8eff822
Compare
m30m
reviewed
Dec 15, 2024
| .await | ||
| .map_err(|e| ClientError::WsConnectFailed(e.to_string()))?; | ||
|
|
||
| let (request_sender, request_receiver) = mpsc::unbounded_channel(); |
There was a problem hiding this comment.
do you know why they made that decision? Which variant do you think makes more sense in our usecase?
m30m
approved these changes
Dec 16, 2024
m30m
reviewed
Dec 16, 2024
| @@ -71,7 +72,10 @@ pub mod nullable_datetime { | |||
| S: Serializer, | |||
| { | |||
| match b { | |||
| Some(b) => s.serialize_str(b.to_string().as_str()), | |||
| Some(b) => { | |||
| let formatted = b.format(&Rfc3339).map_err(ser::Error::custom)?; | |||
There was a problem hiding this comment.
what I meant was what is the difference of this and the previous logic we used
| @@ -36,7 +36,6 @@ fn build_evm_contracts() { | |||
| } | |||
| } | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
we can simplify this build script as well since we have committed the json files
guibescos
reviewed
Dec 16, 2024
| @@ -0,0 +1,17 @@ | |||
| name: Publish Express Relay Client to crates.io | |||
There was a problem hiding this comment.
Seems weird that both github workflows have the same name and job name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to add rust sdk for express relay