Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix how delayed events are sent/resolved #78

Merged
merged 2 commits into from
Jun 13, 2024
Merged

fix how delayed events are sent/resolved #78

merged 2 commits into from
Jun 13, 2024

Conversation

ayazabbas
Copy link
Contributor

No description provided.

@ayazabbas ayazabbas requested a review from ali-bahjati June 13, 2024 09:42
@ayazabbas
Copy link
Contributor Author

ayazabbas commented Jun 13, 2024 •
edited
Loading

This fixes a bug I introduced in my last PR where the same alerts of different event types were overwriting each other in the open_alerts and delayed_events lists. Now we record the alert once in open_alerts but it gets multiple entries in delayed_events for each event type.

ali-bahjati
ali-bahjati approved these changes Jun 13, 2024
View reviewed changes
Copy link
Contributor

@ali-bahjati ali-bahjati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bump the version too?

@ayazabbas ayazabbas merged commit 95f890c into main Jun 13, 2024
3 checks passed
@ayazabbas ayazabbas deleted the AA_fix-sending-delayed-events branch June 13, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ali-bahjati ali-bahjati ali-bahjati approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ayazabbas @ali-bahjati