Remove the redirect FilterList on migration #1109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pydis-static ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This redirect filter list does not have any filters, nor does it have a bot implementation. It is something that we were working on, but has been stalled for a while. The presence of this filter list also causes the bot to warn on startup due to it finding a filter list with no implementation. This commit removes the FilterList, which can be added back if/when we support this filter type in bot.
ChrisLovering
force-pushed
the
remove-the-redirect-filter-list
branch
from
afe6c93 to
be6b698
Compare
ChrisLovering
commented
Sep 19, 2023
|
|
||
|
|
||
| def forward(apps: Apps, _: BaseDatabaseSchemaEditor) -> None: | ||
| apps.get_model("api", "FilterList").objects.filter(name="redirect").delete() |
There was a problem hiding this comment.
api.Filter has on_delete set to cascade set on the filter_list_id foreign key, so deleting the FilterList will delete the Filters for that list automatically.
jchristgit
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1110 Closes BOT-3FA
This redirect filter list does not have any filters, nor does it have a bot implementation.
It is something that we were working on, but has been stalled for a while.
The presence of this filter list also causes the bot to warn on startup due to it finding a filter list with no implementation.
This commit removes the FilterList, which can be added back if/when we support this filter type in bot.
An export of this filter list prior to deletion can be found on this notion page (for those with access).