New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No byteswarning #1290

Open

Kriechi wants to merge 3 commits into python-hyper:master from Kriechi:no-byteswarning

Member

Kriechi commented Nov 23, 2024

super-seeds and closes #1286, #1236

@BYK please review. I combined most of your previous commits from #1286, so the only code change should be in my most recent commit on this PR.

BYK and others added 3 commits

November 23, 2024 11:44


          fix: No more BytesWarnings

Fixes python-hyper#1236.

This patch makes all header operations operate on `bytes` and converts all headers and values to bytes before operation. With a follow up patch to `hpack` it should also increase efficiency as currently, `hpack` casts everything to a `str` first before converting back to bytes: https://github.com/python-hyper/hpack/blob/02afcab28ca56eb5259904fd414baa89e9f50266/src/hpack/hpack.py#L150-L151


          add more upstream tests


          refactor headers bytes encoding

5c6a7f5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet