This repository has been archived by the owner on Jan 13, 2021. It is now read-only.
HTTP20Adapter.close tests (supersedes #307) #344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lukasa
suggested changes
Jul 31, 2017
|
I've added that check to these two tests instead of creating a new one. Let me know if you think that this should be checked in a separate test. |
Lukasa
suggested changes
Jul 31, 2017
test/test_integration.py
Outdated
|
|
||
| # check that all connections are actually closed | ||
| assert (connections_before_close and | ||
| all(conn._sock is None for conn in connections_before_close)) |
There was a problem hiding this comment.
Let's split the first assertion out and call it when we get the connections initially.
test/test_integration.py
Outdated
|
|
||
| # check that all connections are actually closed | ||
| assert (connections_before_close and | ||
| all(conn._sock is None for conn in connections_before_close)) |
Lukasa
approved these changes
Jul 31, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
close()method implementation to the requests adapter and integration tests for it.Supersedes #307
Related issue: #306