This repository has been archived by the owner on Jan 13, 2021. It is now read-only.
Add '@=' separator to pass JSON objects via CLI #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 14, 2018 09:32
The current '=' separator enables to add key-value pairs as strings in a JSON object to the HTTP body. But there's no way to provide more complex JSON objects This commit introduces a new '@=' that adds a key-value pair where the right value is evaluated to a JSON object, allowing more complex structures in the HTTP body. Change-Id: I126a6c8529a6dbf9108b904b2b4d93ef60309113
Change-Id: I94612a7de6f1673703571aa41679a3268086b6ba
hyper/cli.py
Outdated
|
|
||
| '@=' JSON data fields | ||
|
|
||
| name='{"name": "John", "surname": "Doe"}' list='[1, 2, 3]' |
There was a problem hiding this comment.
Shouldn't it have @= there too, like name@='{"name": "John", "surname": "Doe"}' list@='[1, 2, 3]', or am I missing something?
There was a problem hiding this comment.
You're completely right, I'll fix that. Thanks for noticing
Change-Id: I09cc41bead0f1ccea0d5b0c332816d2e69b2d44d
|
Is there any additional change needed to accept the pull request? In case anything else is needed please don't hesitate to ask for it Cheers! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current '=' separator enables to add key-value pairs as strings
in a JSON object to the HTTP body. But there's no way to provide
more complex JSON objects
This commit introduces a new '@=' that adds a key-value pair where
the right value is evaluated to a JSON object, allowing more complex
structures in the HTTP body.
Change-Id: I126a6c8529a6dbf9108b904b2b4d93ef60309113