Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Question: Why is v3.4.0 not yet released to PyPI? #485

Closed
chdinesh1089 opened this issue Jun 28, 2020 · 13 comments
Closed

Question: Why is v3.4.0 not yet released to PyPI? #485

chdinesh1089 opened this issue Jun 28, 2020 · 13 comments

Comments

@chdinesh1089
Copy link

Are there any issues with this release or is it something else? When can we expect this in PyPI?
@chdinesh1089 chdinesh1089 mentioned this issue Jun 28, 2020
Closed
@ozren1983
Copy link

Any updates on this questions?

@timmc-edx
Copy link

It looks like the Travis build hung on some of the environments: https://travis-ci.org/github/python-social-auth/social-core/builds/700507848

I tried running tests locally by entering a Python 3.5 virtualenv and running pip install tox tox-travis -U pip and then tox. Just like on Travis, my tests hung at social_core/tests/backends/test_google.py::GoogleOpenIdTest::test_login. This also fails on existing version 3.3.3.

This seems to be related to a mocking issue in Google OpenID tests:

If those tests are fixed, maybe a 3.4.1 can be cut.

If social_core/tests/backends/test_google.py::GoogleOpenIdTest is deleted, all other tests pass, and it looks like there hasn't been any direct work on the Google integration since v3.3.3... so I'd say it's safe to depend on git+https://github.com/python-social-auth/social-core.git@9d93069564a60495e0ebd697b33e16fcff14195b#egg=social-auth-core==3.4.0 for now.

timmc-edx added a commit to openedx/edx-platform that referenced this issue Jul 24, 2020
@timmc-edx
Depend on unreleased social-auth-core 3.4.0 for fixes to Apple auth b…
16c3d4f 
…ackend

3.4.0 was not released to PyPI due to a broken test:
python-social-auth/social-core#485

This version contains necessary fixes for validating the "audience"
component of the JWT, as seen in ARCHBOM-1281. (I believe we'll need to
pass both the App ID and the Service ID in an additional AUDIENCE "other
settings" key for this third-party-auth backend.)
@timmc-edx timmc-edx mentioned this issue Jul 24, 2020
Closed
timmc-edx added a commit to openedx/edx-platform that referenced this issue Jul 28, 2020
@timmc-edx
Depend on unreleased social-auth-core 3.4.0 for fixes to Apple auth b…
ccd6f5c 
…ackend

3.4.0 was not released to PyPI due to a broken test:
python-social-auth/social-core#485

This version contains necessary fixes for validating the "audience"
component of the JWT, as seen in ARCHBOM-1281. (I believe we'll need to
pass both the App ID and the Service ID in an additional AUDIENCE "other
settings" key for this third-party-auth backend.)
@timmc-edx timmc-edx mentioned this issue Jul 28, 2020
Merged
1 task
timmc-edx added a commit to openedx/edx-platform that referenced this issue Jul 29, 2020
@timmc-edx
ARCHBOM-1281: Vendor in AppleID backend to support Sign-In With Apple
a44444d 
This version contains necessary fixes for validating the "audience"
component of the JWT, as seen in ARCHBOM-1281. (I believe we'll need to
pass both the App ID and the Service ID in an additional AUDIENCE "other
settings" key for this third-party-auth backend.)

Vendored from version 3.4.0 (9d93069564a60495e0ebd697b33e16fcff14195b)
social-core:
https://github.com/python-social-auth/social-core/blob/3.4.0/social_core/backends/apple.py

v3.4.0 is unreleased at this time (2020-07-28) and contains several
necessary bugfixes over 3.3.3 for AppleID, but also causes the
TestShibIntegrationTest.test_full_pipeline_succeeds_for_unlinking_testshib_account
test in common/djangoapps/third_party_auth/tests/specs/test_testshib.py
to break (somehow related to social-core's change 561642bf which makes
a bugfix to partial pipeline cleaning). ARCHBOM-1389 filed to address
this at our convenience.

Note: 3.4.0 was not released to PyPI due to a broken test, so we might
see a 3.4.1 when it's actually released:
python-social-auth/social-core#485
timmc-edx added a commit to openedx/edx-platform that referenced this issue Aug 6, 2020
@timmc-edx
ARCHBOM-1281: Vendor in AppleID backend to support Sign-In With Apple (…
b64c8c2 
…#24623)

This version contains necessary fixes for validating the "audience"
component of the JWT, as seen in ARCHBOM-1281. (I believe we'll need to
pass both the App ID and the Service ID in an additional AUDIENCE "other
settings" key for this third-party-auth backend.)

Vendored from version 3.4.0 (9d93069564a60495e0ebd697b33e16fcff14195b)
social-core:
https://github.com/python-social-auth/social-core/blob/3.4.0/social_core/backends/apple.py

v3.4.0 is unreleased at this time (2020-07-28) and contains several
necessary bugfixes over 3.3.3 for AppleID, but also causes the
TestShibIntegrationTest.test_full_pipeline_succeeds_for_unlinking_testshib_account
test in common/djangoapps/third_party_auth/tests/specs/test_testshib.py
to break (somehow related to social-core's change 561642bf which makes
a bugfix to partial pipeline cleaning). ARCHBOM-1389 filed to address
this at our convenience.

Note: 3.4.0 was not released to PyPI due to a broken test, so we might
see a 3.4.1 when it's actually released:
python-social-auth/social-core#485
@jhnbkr
Copy link

jhnbkr commented Aug 27, 2020

+1 we are relying on a fix for Apple ID. Is there anything I can do to help push a 3.4.x release out?

@timmc-edx
Copy link

I eventually resorted to pasting the appleid.py file (with the repo license on top) into our project, which unblocked us on Apple ID. It's possible that you could use the unreleased version but it caused other test failures for us.

@mateuszmandera
Copy link
Contributor

it caused other test failures for us

@timmc-edx Does this mean there are regressions in 3.4.0? Which backends have been the problem for you?

@timmc-edx
Copy link

timmc-edx commented Sep 21, 2020 •
edited
Loading

I don't know if there's a real regression.

We saw a test failure somewhere in a fairly involved test that may or may not be a "legitimate" failure. It started after a commit in social-auth that fixed a pipeline bug (561642bf) so it might just be a problem with how our test was set up. The test in question appears to use the SAML backend.

It might work fine, but we were on a deadline and there wasn't a proper release to upgrade to anyhow, so we'll probably hold off on looking into that test failure until social-auth cuts a new release.

@mateuszmandera
Copy link
Contributor

@timmc-edx I see, thanks for explaining that!

@andersk
Copy link
Contributor

andersk commented Oct 24, 2020

I’ve submitted #515 to remove the discontinued Google OpenID backend and get Travis passing again.

@nijel nijel mentioned this issue Nov 10, 2020
Open
@stale
Copy link

stale bot commented Dec 23, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Stale issues (closing soon) label Dec 23, 2020
@andersk
Copy link
Contributor

andersk commented Dec 23, 2020

Go away, stale bot.

@stale stale bot removed the stale Stale issues (closing soon) label Dec 23, 2020
@omab
Copy link
Contributor

omab commented Jan 10, 2021

Version 4.0.2 got released today.

@omab omab closed this as completed Jan 10, 2021
@timmc-edx
Copy link

@omab Will 3.4.0 be released? It never made it to PyPI.

@omab
Copy link
Contributor

omab commented Jan 11, 2021

@timmc-edx, for leagacy purposes, I've released 3.4.0 into pypi as well.

@timmc-edx timmc-edx mentioned this issue Jun 6, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@andersk @omab @jhnbkr @ozren1983 @chdinesh1089 @mateuszmandera @timmc-edx