-
-
Notifications
You must be signed in to change notification settings - Fork 546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect base url for azuread b2c backend #809
Comments
When I put together the PR, I didn't take into account the custom domains feature of b2c. I was just using b2clogin.com. Does it make sense to create a separate backend like azuread-b2c-custom-oauth2 for custom domains? |
I think the change also broke the URL for endpoints which do not contain a policy parameter, as described in https://learn.microsoft.com/en-us/azure/active-directory-b2c/b2clogin#endpoints-that-are-not-affected Obviously Microsoft has now (at least) three different ways to compose the base url which need to be distinguished. |
It would also be great to cover this topic in the documentation so that users know which backend to choose in which situation: https://github.com/python-social-auth/social-docs/blob/master/docs/backends/azuread.rst |
As per this documentation, I think the base URL for backend "azuread-b2c-oauth2" for custom domain should be
BASE_URL = "https://{authority_host}/{tenant_name}.onmicrosoft.com"
but not
BASE_URL = "https://{tenant_name}.{authority_host}/{tenant_name}.onmicrosoft.com"
From Azure documentation:
The text was updated successfully, but these errors were encountered: