-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build and publish aarch64 wheels #100
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @vermut !
A nitpic and we will be good to go.
I am OK to publish aarch64 wheels only on Linux. If more platforms are needed in the future, we will tackle the need at that time.
name: python-package-distributions-macos | ||
path: ./wheelhouse/*.whl | ||
- uses: actions/upload-artifact@v4 | ||
with: | ||
name: python-package-distributions-linux | ||
path: ./wheelhouse/*.whl |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this could be simplified to:
name: python-package-distributions-macos | |
path: ./wheelhouse/*.whl | |
- uses: actions/upload-artifact@v4 | |
with: | |
name: python-package-distributions-linux | |
path: ./wheelhouse/*.whl | |
name: python-package-distributions-wheels | |
path: ./wheelhouse/*.whl |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, that will work too. Actually I did it differently when testing it in my repo: vermut@1598f50
also note setuptools addition - I had issue with that in on the runs: https://github.com/vermut/marisa-trie/actions/runs/8961082399/job/24608308956
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your version is way better, could you apply it here too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, and you already fixed the setuptools
issue. Let's also fix it in that PR :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll just create a PR from my master. Squash the WIP commits when merging.
Could you please add aarch64 to the list of published archs? We, users of HomeAssistant, found out that mandatory upgrade to 3.12 left us without compiled version, and default image doesn't have gcc to build our own.
DurgNomis-drol/ha_toyota#258
I'm proposing a PR that I partially tested: https://github.com/vermut/marisa-trie/actions/runs/8959884430, but not full version with mac and win. So I'm not sure about double
actions/upload-artifact@v4