Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build and publish aarch64 wheels #100

Closed
wants to merge 1 commit into from
Closed

Conversation

vermut
Copy link
Contributor

@vermut vermut commented May 5, 2024

Could you please add aarch64 to the list of published archs? We, users of HomeAssistant, found out that mandatory upgrade to 3.12 left us without compiled version, and default image doesn't have gcc to build our own.
DurgNomis-drol/ha_toyota#258

I'm proposing a PR that I partially tested: https://github.com/vermut/marisa-trie/actions/runs/8959884430, but not full version with mac and win. So I'm not sure about double actions/upload-artifact@v4

Copy link
Contributor

@BoboTiG BoboTiG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @vermut !

A nitpic and we will be good to go.

I am OK to publish aarch64 wheels only on Linux. If more platforms are needed in the future, we will tackle the need at that time.

Comment on lines 50 to +55
name: python-package-distributions-macos
path: ./wheelhouse/*.whl
- uses: actions/upload-artifact@v4
with:
name: python-package-distributions-linux
path: ./wheelhouse/*.whl
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this could be simplified to:

Suggested change
name: python-package-distributions-macos
path: ./wheelhouse/*.whl
- uses: actions/upload-artifact@v4
with:
name: python-package-distributions-linux
path: ./wheelhouse/*.whl
name: python-package-distributions-wheels
path: ./wheelhouse/*.whl

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, that will work too. Actually I did it differently when testing it in my repo: vermut@1598f50

also note setuptools addition - I had issue with that in on the runs: https://github.com/vermut/marisa-trie/actions/runs/8961082399/job/24608308956

This comment was marked as outdated.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your version is way better, could you apply it here too?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, and you already fixed the setuptools issue. Let's also fix it in that PR :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll just create a PR from my master. Squash the WIP commits when merging.

@vermut vermut closed this May 6, 2024
@vermut vermut deleted the patch-1 branch May 6, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants