Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete the plural on counters at 0 #866

Open
sebastiendelorme opened this issue Dec 21, 2020 · 2 comments
Open

Delete the plural on counters at 0 #866

sebastiendelorme opened this issue Dec 21, 2020 · 2 comments

Comments

@sebastiendelorme
Copy link

sebastiendelorme commented Dec 21, 2020

For each counter, Q2A differentiate singular and plural words:

  • 1 question
  • X questions

For example, on Categories.php:

$qcountHtml = $editcategory['qcount'] == 1
	? qa_lang_html_sub('main/1_question', '1', '1')
	: qa_lang_html_sub('main/x_questions', qa_format_number($editcategory['qcount']));

But, if there is 0 question, it display "0 questions" instead of "0 question".
Same issue on 'x_answers', 'x_comments', 'x_points', 'x_views', 'x_votes', etc.

I think it could be interested to change by something like (for example):

$qcountHtml = $editcategory['qcount'] <= 1
	? qa_lang_html_sub('main/x_question', qa_format_number($editcategory['qcount']))
	: qa_lang_html_sub('main/x_questions', qa_format_number($editcategory['qcount']));
@svivian
Copy link
Collaborator

svivian commented Jan 2, 2021

"0 questions" is the correct English. Are you using a different language where this is not the case?

@sebastiendelorme
Copy link
Author

Thank you for your reply.
Sorry, I didn't know the rule for English.

Yes, I'm using French, and we are accustomed to using singular with 0 :
http://bdl.oqlf.gouv.qc.ca/bdl/gabarit_bdl.asp?id=3642 (see last examples).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants