Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't rely on PR description to identify the package #71

Open
ericLemanissier opened this issue Feb 10, 2022 · 0 comments
Open

don't rely on PR description to identify the package #71

ericLemanissier opened this issue Feb 10, 2022 · 0 comments

Comments

@ericLemanissier
Copy link
Contributor

an example of failure is conan-io/conan-center-index#9330, which is associated by your bot to tensorflow-lite/2.8.0 because this reference happens to appear in the pull request description, but the PR is in fact for xnnpack/cci.20211210
A more reliable solution would be to do the following:
for each updatable package (package/version)and for each pull request
-download the PR's recipes/package/config.yml file

  • search if version is listed in config.yml

if the quadratic nature of this solution seems inapropriate, then you could checkout each PR's branch, and find the package it modifies by calling git show --first-parent --name-only

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant