-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Polish Qibo cloud #1241
Polish Qibo cloud #1241
Conversation
The motivation for the rename is that (you can think as Sorry not to have pointed out when we discussed the naming in #1157 |
No, indeed, I was planning of changing it in the |
The rationale for the dependency removal is instead the same of Currently (before |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1241 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 73 73
Lines 10531 10531
=========================================
Hits 10531 10531
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@alecandido thanks. At the end you are not moving the cloud-backends dependency to tests, right? |
I scan through it, and it seems the two backends are not currently used in tests, thus there is no need for the dependency. Can you confirm this @BrunoLiegiBastonLiegi? |
Yes I can confirm, their tests are in |
Ok, thanks, could you please fix the conflict and merge? |
133d8e2
to
eff6478
Compare
Conflicts just fixed, I'm just waiting for the tests to pass |
Sorry @BrunoLiegiBastonLiegi, there is some aftermath after closing #1157, I didn't notice during the review.
"qibo-client"
qibo-cloud-backends
dependencyCloses #1240