Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove TensorFlow dependency #734

Closed
alecandido opened this issue Feb 28, 2024 · 1 comment · Fixed by #750
Closed

Remove TensorFlow dependency #734

alecandido opened this issue Feb 28, 2024 · 1 comment · Fixed by #750
Assignees
Milestone

Comments

@alecandido
Copy link
Member

alecandido commented Feb 28, 2024

TensorFlow is only required for the classifiers, but it has been shown by @Edoardo-Pedicillo that the classifiers available in scikit-learn are already good enough, at least for the time being.

TensorFlow is a complex dependency, with multiple sub-packages, and not always promptly distributing wheels (and possibly not for all platforms), unlike NumPy, e.g..

Most likely, upgrading to the last release candidate could be enough, as it will already be in Qibo.
qiboteam/qibo#1231 (comment)
But if it is not strictly needed, I'd make our lives easier and drop it, together with the related code.

Note

I'm not suggesting to drop the classifiers and their infrastructure at all. The qubit fit and the scikit-learn ones are not causing any issue, and they could be very valuable.

@rscircus
Copy link

+1 - we also have issues with them all the time + google product half-life is low

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants