Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor QM sweepers implementation #1070

Open
alecandido opened this issue Oct 11, 2024 · 0 comments
Open

Refactor QM sweepers implementation #1070

alecandido opened this issue Oct 11, 2024 · 0 comments
Labels
refactor Code is working but could be simplified

Comments

@alecandido
Copy link
Member

I have the feeling we start doing something wrong in here: max_offset seems not to be a property of Parameters, but just propagating a property of the instrument's configuration (or better, the port, since you should be able to control them individually).

Maybe it's fine to package it together with the other parameters, but I'm not fully convinced.
In general, this class seems to have a lot of parameters, many of which are only needed "sometimes", and others which are propagating parameters of something else.

Maybe we should rethink how sweepers are generated, and what they get access to.
In any case, this is definitely not urgent, and just a refactoring (if needed at all). So, it could be split as an issue. Unless there is a motivation to keep it as it is, in which case we could even save the issue.

Originally posted by @alecandido in #1068 (comment)

@alecandido alecandido added the refactor Code is working but could be simplified label Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Code is working but could be simplified
Projects
None yet
Development

No branches or pull requests

1 participant