You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I have the feeling we start doing something wrong in here: max_offset seems not to be a property of Parameters, but just propagating a property of the instrument's configuration (or better, the port, since you should be able to control them individually).
Maybe it's fine to package it together with the other parameters, but I'm not fully convinced.
In general, this class seems to have a lot of parameters, many of which are only needed "sometimes", and others which are propagating parameters of something else.
Maybe we should rethink how sweepers are generated, and what they get access to.
In any case, this is definitely not urgent, and just a refactoring (if needed at all). So, it could be split as an issue. Unless there is a motivation to keep it as it is, in which case we could even save the issue.
I have the feeling we start doing something wrong in here:
max_offset
seems not to be a property ofParameters
, but just propagating a property of the instrument's configuration (or better, the port, since you should be able to control them individually).Maybe it's fine to package it together with the other parameters, but I'm not fully convinced.
In general, this class seems to have a lot of parameters, many of which are only needed "sometimes", and others which are propagating parameters of something else.
Maybe we should rethink how sweepers are generated, and what they get access to.
In any case, this is definitely not urgent, and just a refactoring (if needed at all). So, it could be split as an issue. Unless there is a motivation to keep it as it is, in which case we could even save the issue.
Originally posted by @alecandido in #1068 (comment)
The text was updated successfully, but these errors were encountered: