You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As I said before, I believe that this could be non-driver-specific.
However, the implementation is very minimal, and with the current architecture is definitely needed. So, it is definitely fine for this PR.
But, having even seen the content of this, I'd try to take some time to attempt fully lifting components to the general Qibolab part.
(Specifically, the only bits that I believe are truly specific to QM in these components are the name of the attributes, the specific port layout - which can be converted - and the serial property, which could be just a function)
As I said before, I believe that this could be non-driver-specific.
However, the implementation is very minimal, and with the current architecture is definitely needed. So, it is definitely fine for this PR.
But, having even seen the content of this, I'd try to take some time to attempt fully lifting components to the general Qibolab part.
(Specifically, the only bits that I believe are truly specific to QM in these components are the name of the attributes, the specific
port
layout - which can be converted - and theserial
property, which could be just a function)Originally posted by @alecandido in #933 (comment)
The text was updated successfully, but these errors were encountered: