Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify instrument specific components #966

Closed
stavros11 opened this issue Aug 8, 2024 · 1 comment · Fixed by #1001
Closed

Unify instrument specific components #966

stavros11 opened this issue Aug 8, 2024 · 1 comment · Fixed by #1001
Assignees
Milestone

Comments

@stavros11
Copy link
Member

stavros11 commented Aug 8, 2024

As I said before, I believe that this could be non-driver-specific.
However, the implementation is very minimal, and with the current architecture is definitely needed. So, it is definitely fine for this PR.

But, having even seen the content of this, I'd try to take some time to attempt fully lifting components to the general Qibolab part.

(Specifically, the only bits that I believe are truly specific to QM in these components are the name of the attributes, the specific port layout - which can be converted - and the serial property, which could be just a function)

Originally posted by @alecandido in #933 (comment)

@alecandido
Copy link
Member

This is now being addressed by #1001, since it was already convenient

@alecandido alecandido linked a pull request Aug 26, 2024 that will close this issue
7 tasks
@alecandido alecandido self-assigned this Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants