Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parkinson's mouse tutorial should document fragment-insertion filter-features step after fragment-insertion sepp #440

Open
gregcaporaso opened this issue Dec 19, 2019 · 2 comments

Comments

@gregcaporaso
Copy link
Member

Improvement Description
qiime fragment-insertion sepp is applied in the Parkinson's mouse tutorial, but isn't followed with a qiime fragment-insertion filter-features step to remove ASVs that weren't inserted into the tree from the feature table. We should document qiime fragment-insertion filter-features at this point in the tutorial since it is often necessary after running qiime fragment-insertion sepp. This content could be derived from the tutorial provided here.

Current Behavior
It seems that all of the ASVs in this tutorial are successfully inserted into the tree, so there are no failures in downstream steps.

Proposed Behavior
We should document that this step is often necessary to ensure that all of the features in the feature table are also present in the tree. We can note that the filter isn't necessary in this tutorial, but that it often will be. This can happen in a box (probably where we explain how to determine if it's necessary), or just include the filtering command even though it doesn't change anything here (that might be safer in case a change in an upstream step such as denoising results in one or more ASVs not being placed in this process in the future, in which case the build of this tutorial would fail).

@gregcaporaso gregcaporaso changed the title parkinson's mouse tutorial should document filter-features step after qiime fragment-insertion filter-features parkinson's mouse tutorial should document fragment-insertion filter-features step after fragment-insertion sepp Dec 19, 2019
@mestaki
Copy link

mestaki commented Dec 19, 2019

In my own workflows I tend to do the filtering always even though I've actually never had a case yet where features were not inserted into the tree. For reasons Greg mentioned I think this is a better approach than a box .
That being said, I was thinking of opening a new issue to propose a new pipeline where the filtering is done after fragment-insertion in one step, or maybe an easier approach would be simply for fragment insertion to raise a warning when >0 features failed to be placed in the tree and this would advise the user to perform the filtering step. If this makes sense I'll go ahead and create an issue?

@thermokarst
Copy link
Contributor

maybe an easier approach would be simply for fragment insertion to raise a warning when >0 features failed to be placed in the tree and this would advise the user to perform the filtering step. If this makes sense I'll go ahead and create an issue?

Maybe we should return the filtered FeatureData[Sequence] from the sepp command. Then it can be used for downstream filtering pretty easily (also is easily summarized, etc.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants