Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement multiple logging backends #22159

Closed
wants to merge 7 commits into from
Closed

Implement multiple logging backends #22159

wants to merge 7 commits into from

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Sep 28, 2023

Description

Refactored out while debugging hid stuff on the riot port, bit of a chicken/egg situation with the usual console implementation. Removes some bespoke keyboard level logic now a generic implementation exists.

Also a prerequisite for logging over XAP.

Example: Custom logging to OLED

rules.mk

SENDCHAR_DRIVER = custom

keymap.c

int8_t sendchar(uint8_t c) {
    oled_write_char(c, false);
    return 0;
}

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr marked this pull request as ready for review September 29, 2023 14:01
@zvecr zvecr force-pushed the log_driver branch 2 times, most recently from 757bd7b to 98df1b9 Compare November 18, 2023 18:55
@zvecr zvecr added the no-ci Signals to the CI runners not to build. label Nov 18, 2023
@zvecr zvecr force-pushed the log_driver branch 2 times, most recently from 8740dd3 to c386532 Compare November 18, 2023 19:08
@zvecr zvecr removed the no-ci Signals to the CI runners not to build. label Nov 18, 2023
@drashna drashna requested a review from a team December 6, 2023 06:41
Copy link
Member

@KarlK90 KarlK90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works nicely, I have already started to build #22538 on top of this.

builddefs/common_features.mk Show resolved Hide resolved
Copy link

github-actions bot commented Apr 2, 2024

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Apr 2, 2024
@KarlK90
Copy link
Member

KarlK90 commented Apr 2, 2024

Needs some rebasing after #21656 landed.

@KarlK90 KarlK90 removed the stale Issues or pull requests that have become inactive without resolution. label Apr 2, 2024
@KarlK90
Copy link
Member

KarlK90 commented Aug 10, 2024

Oh well, quite the fallout with the uart driver on the onekeys. But this finally gives us more coverage of that subsystem across all platforms.

@tzarc tzarc self-requested a review August 13, 2024 00:27
@tzarc tzarc added the develop-fast-track Intended to be merged early in the next develop cycle. label Aug 25, 2024
@drashna drashna requested a review from a team August 26, 2024 01:08
@KarlK90
Copy link
Member

KarlK90 commented Sep 10, 2024

@zvecr I took the liberty (hope you don't mind) and fixed the compilation failures and removed the atsam integration. With that the PR should be mergable again.

@zvecr
Copy link
Member Author

zvecr commented Sep 10, 2024

In future I would rather you didn't, and let me know. Its not like i'm not active.

@KarlK90
Copy link
Member

KarlK90 commented Sep 10, 2024

In future I would rather you didn't, and let me know. Its not like i'm not active.

Understood. Is collaboration on your PRs generally not welcome or were the unsolicited commits, for example, okay if you were asked beforehand?

@zvecr
Copy link
Member Author

zvecr commented Sep 10, 2024

Pushing to someone elses branch without notice isnt collaboration. Force pushing, thats just hostile.

@KarlK90
Copy link
Member

KarlK90 commented Sep 10, 2024

Pushing to someone elses branch without notice isnt collaboration. Force pushing, thats just hostile.

I didn't mean to be hostile and I'm sorry that it came across as such.

@zvecr
Copy link
Member Author

zvecr commented Sep 10, 2024

Nah its all good, this PR has been around a while so I get the intention to try and drive it over the line.

@zvecr
Copy link
Member Author

zvecr commented Oct 9, 2024

Yet another area that has become impossible to make improvements in.

@zvecr zvecr closed this Oct 9, 2024
@zvecr zvecr deleted the log_driver branch October 9, 2024 09:47
@zvecr zvecr restored the log_driver branch October 9, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting review core develop-fast-track Intended to be merged early in the next develop cycle. enhancement keyboard keymap
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants