-
-
Notifications
You must be signed in to change notification settings - Fork 39.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement multiple logging backends #22159
Conversation
757bd7b
to
98df1b9
Compare
8740dd3
to
c386532
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works nicely, I have already started to build #22538 on top of this.
Thank you for your contribution! |
Needs some rebasing after #21656 landed. |
Oh well, quite the fallout with the uart driver on the onekeys. But this finally gives us more coverage of that subsystem across all platforms. |
@zvecr I took the liberty (hope you don't mind) and fixed the compilation failures and removed the atsam integration. With that the PR should be mergable again. |
In future I would rather you didn't, and let me know. Its not like i'm not active. |
Understood. Is collaboration on your PRs generally not welcome or were the unsolicited commits, for example, okay if you were asked beforehand? |
Pushing to someone elses branch without notice isnt collaboration. Force pushing, thats just hostile. |
I didn't mean to be hostile and I'm sorry that it came across as such. |
Nah its all good, this PR has been around a while so I get the intention to try and drive it over the line. |
Yet another area that has become impossible to make improvements in. |
Description
Refactored out while debugging hid stuff on the riot port, bit of a chicken/egg situation with the usual console implementation. Removes some bespoke keyboard level logic now a generic implementation exists.
Also a prerequisite for logging over XAP.
Example: Custom logging to OLED
rules.mk
keymap.c
Types of Changes
Issues Fixed or Closed by This PR
Checklist