Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popup action download key not triggering #1387

Open
lnp5131 opened this issue Dec 10, 2024 · 2 comments
Open

Popup action download key not triggering #1387

lnp5131 opened this issue Dec 10, 2024 · 2 comments
Labels
bug Something isn't working topic:userscript

Comments

@lnp5131
Copy link

lnp5131 commented Dec 10, 2024

It takes several attempts for the download to trigger when using the shortcut. Clicking the popup will download immediately. So far tested on google images. There seems to be a difference between clicking the popup and using the download shortcut. If the shortcut could share the same code as clicking that would be desirable.

@qsniyg qsniyg added bug Something isn't working topic:userscript labels Dec 10, 2024
@qsniyg
Copy link
Owner

qsniyg commented Dec 10, 2024

Try disabling Use GM_download if available (under General), see if it makes a difference.

@lnp5131
Copy link
Author

lnp5131 commented Dec 10, 2024

Try disabling Use GM_download if available (under General), see if it makes a difference.

Currently using the Firefox extension, I don't see that option. Is there a development XPI?
Edit: Just checked the userscript version too, I don't see that option, but I do see it in the userscript code.
Edit2: I disabled the addon while the userscript is enabled and the option appeared. With GM_download enabled, it opens up a save dialog, which is undesirable. It then opens a tab after the dialog. With GM_download disabled, it opens a tab without attempting to save. This applies to both the click and shortcut. The speed seems to be about the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working topic:userscript
Projects
None yet
Development

No branches or pull requests

2 participants