-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better input system #138
Comments
By edit, do you mean before sending or after sending? |
Before sending message. The editing of the first line works well, but once a new line is inserted by line warping, it becomes impossible to edit the first line. |
huh, that doesn't happen for me. what terminal are you using? |
I have this problem on Konsole, Alacritty, and st. |
here's an asciinema of what I see: https://asciinema.org/a/1dhK4SCMVSAnm8l6FFBdvxtcZ (unrelated but this shows the line counting algo is broken) could you send an asciinema of what you see? |
You can see it here. When you use the raw cast file, if the terminal window is wide enough, it looks normal. But when it is the proper size, it looks like what I had, which is very funky. I thik the issue comes from the fact that Devzat does not try to handle multiple lines and move the cursor around when editing a message. I saw the issue #140 and the related code and it doesn't look like the code can handle all cases. |
Wow um yeah input is really jank lol |
I looked at potential solutions and Bubbles' textinput looks like a pretty decent solution for us. Do you think I should look into integrating it? |
After looking at Bubble Tea, it seems that the inputs are very abstracted. Thus, getting the inputs from the user might be tricky. Bubble Tea might not be the solution to our problem. |
I see |
The input in Devzat is quite poor. The fact that it is not possible to comfortably edit multi-lines messages is a bit sad. We should probably refactor that system. Maybe there are some external library to handle that kind of tasks.
The text was updated successfully, but these errors were encountered: