Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make messages a new struct / in general make stuff less hacky #31

Open
quackduck opened this issue Jun 14, 2021 · 6 comments
Open

Make messages a new struct / in general make stuff less hacky #31

quackduck opened this issue Jun 14, 2021 · 6 comments

Comments

@quackduck
Copy link
Owner

Then we could have better detection if messages are dms, instead of the hacky way (as I note in the comment) we do this detection rn:

if strings.HasSuffix(senderName, " <- ") || strings.HasSuffix(senderName, " -> ") { // kinda hacky

https://github.com/quackduck/devzat/blob/main/devchat.go#L265

@quackduck
Copy link
Owner Author

We could also have some other fun stuff with this feature, plus cleaner and more oop I guess

@quackduck quackduck changed the title Make messages a new struct Make messages a new struct / in general make stuff less hacky Jun 14, 2021
@patrickhener
Copy link

Yeah for example you could break out the dm to an own command like ./dm @someone <message>?

@quackduck
Copy link
Owner Author

Actually we had that exact command but moved to = cause it’s easier to type

@quackduck
Copy link
Owner Author

@patrickhener so we already have that lol

@patrickhener
Copy link

fine

@quackduck
Copy link
Owner Author

yup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants