Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OIDC: Further improve mobile auth flow #12

Open
michele-franchi opened this issue Oct 7, 2024 · 10 comments · May be fixed by #13
Open

OIDC: Further improve mobile auth flow #12

michele-franchi opened this issue Oct 7, 2024 · 10 comments · May be fixed by #13
Assignees

Comments

@michele-franchi
Copy link

michele-franchi commented Oct 7, 2024

The mobile auth flow can be further improved:

  • Sometimes after pressing "Connect" on the wallet side on iOS, siwe-oidc UI does not prompt to sign the message (it happens with different wallets but especially with Metamask). Need to discover if this is an issue with wallets or with our setup.
@michele-franchi michele-franchi changed the title Further improve mobile auth flow OIDC: Further improve mobile auth flow Oct 15, 2024
@subhod-i subhod-i linked a pull request Oct 15, 2024 that will close this issue
@michele-franchi
Copy link
Author

michele-franchi commented Dec 4, 2024

Wallets to be tested (on iOS and Android):

  • MetaMask
  • Trust Wallet
  • Rainbow
  • OXK Wallet
  • Bitget Wallet
  • Binance Wallet
  • Uniswap Wallet
  • SafePal
  • Bybit Wallet

@Liubov-crypto
Copy link

Liubov-crypto commented Dec 4, 2024

Tested with ios app staging.
iOS:
Metamask - lgtm.
I found that connection could stuck on second confirmation on OIDC page, but this could happen if user has already in Metamask previous connection session with quali chat.

Trust wallet - lgtm
Rainbow - lgtm. Second iteration could be slow, because wallet already has connection session when I logged in for the first time.
Bitget Wallet - lgtm
Binance Wallet - lgtm
Uniswap Wallet - lgtm. But chat haven't asked me to backup my session key. We had this issue before:
https://github.com/user-attachments/assets/99caa489-34a4-4dc1-964d-f45b3edee846

SafePal - lgtm

Bybit Wallet, OXK Wallet - have to create wallets to test it.

@Liubov-crypto
Copy link

iOS app, tested with iOS app quali.chat.staging 1.0 (18):
Bybit Wallet - I've logged in from second attempt. I have to choose only ETH network in wallet to be able to connect with quali chat. When I was using all networks by default I haven't received a confirmation screen to connect with chat. When I logged out chat haven't asked me to backup my session key.
I retested it again (in wallet all networks were active by default) this time connection went smoothly. When I logged out chat haven't asked me to backup my session key.

OXK Wallet - lgtm. When I logged out chat haven't asked me to backup my session key.

@achristopoulos894
Copy link

Tested of Pixel 7 Android 15 and Samsung Galaxy A40s Android 14.

For samsung Galaxy A40s:

  • Metamask: could not login with metamask. It took a very long time for metamask app to open and display the authorization message.
  • Trust: LGTM.
  • Rainbow: LGTM. 1st and 2nd login was effortless
  • OXK Wallet: Was able to login. However after approving from OXK wallet the user is redirected to Google Chrome app. Had to manually go open quali.chat app and continue the process.
  • Bitget Wallet: Could not login. Multiple approval messages were displayed on the Bitget wallet. After approving one of the messages nothing happens
  • Uniswap: LGTM
  • Safepal: LGTM
  • Bybit Wallet: Could not login.

For Pixel 7

  • Metamask: LGTM. I had some issues were approval pop ups on metamask took a very long time to appear.
  • Trust: LGTM
  • Rainbow: LGTM
  • OXK Wallet: Same issues as galaxt A40s
  • Bitget: Could not login. Same issues as galaxy A40s
  • Uniswap: LGTM
  • Safepal: LGTM
    • Bybit Wallet: Could not login.

@Liubov-crypto
Copy link

Liubov-crypto commented Dec 5, 2024

Extensions for Chrome browser: Tested on MacOS with https://app.staging.quali.chat/:

MetaMask - lgtm
Trust Wallet - lgtm
Rainbow - lgtm
Uniswap Wallet - lgtm
SafePal - lgtm

OXK Wallet - I signed confirmation popups successfully but was not logged in on final step to chat.
https://github.com/user-attachments/assets/d412321c-9b8b-416c-a45d-ce8d59f8f2d3
Image

Bitget Wallet - The same issue as with OKX wallet - I signed confirmation popups successfully but was not logged in on final step to chat.
https://github.com/user-attachments/assets/5cbd362a-a31b-4e61-8968-15857855c57b

Bybit Wallet - chat has not detected bybit wallet extension. I can't login.
https://github.com/user-attachments/assets/72af2920-7026-4586-b2c7-31c1f2b5601b
Image

Binance Wallet - there is no extension for Binance wallet.

@achristopoulos894
Copy link

Tested https://app.staging.quali.chat/#/login

On Chrome:

  • Metamask: First login was successful. 2nd login was not successful and I could not disconnect. I had to clear cookies/data. Image
  • Trust wallet: Was not able to login. tried 5 times (clearing data/cookies, clearing session from trust app). After last auth prompt the following screen was displayed: Image
  • Rainbow: 1st login was ok. could not connect on 2nd login.
  • OKX Wallet: Ok
  • Bitget: Sometimes the extension was not enabled.
  • Uniswap: Ok
  • Safepal: Ok
  • Bybit: OK

@achristopoulos894
Copy link

On Firefox:

Metamask; 1st and 2nd login OK.
Trust wallet -does not have extension
Rainbow- 1st and 2nd login OK.
OXK - not extension
Bitget Wallet -does not have extension
Uniswap Wallet - does not have extension
SafePal - 1st and 2nd login OK
Bybit Wallet -does not have extension

@Liubov-crypto
Copy link

Extensions for Firefox browser. Tested on MacOS with https://app.staging.quali.chat/:

MetaMask - lgtm
Trust Wallet - not available in FF
Rainbow - lgtm. When logged out was not asked to backup my security key.
OXK Wallet - not available in FF
Bitget Wallet - not available in FF
Binance Wallet - not available in FF
Uniswap Wallet - not available in FF
SafePal -lgtm
Bybit Wallet - not available in FF

@Liubov-crypto
Copy link

Extensions for Opera browser. Tested on MacOS with https://app.staging.quali.chat/:

MetaMask - logged in with chrome extension. I was not asked to backup my security key when logged out.
Trust Wallet - logged in with chrome extension. I was not asked to backup my security key when logged out.
Rainbow - logged in with chrome extension. I was not asked to backup my security key when logged out.
SafePal - logged in with chrome extension. I was not asked to backup my security key when logged out.
Binance Wallet - doesn't have an extension
Uniswap Wallet - doesn't have an extension

@michele-franchi
Copy link
Author

After the testing phase, wallets got restricted to:

  • Metamask
  • Trust Wallet
  • Rainbow
  • Uniswap
  • Safepal
  • Binance (Mobile only)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants