Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new annotations in service.yaml #158

Open
wgresshoff opened this issue Jan 13, 2023 · 3 comments
Open

Add new annotations in service.yaml #158

wgresshoff opened this issue Jan 13, 2023 · 3 comments
Labels
wontfix This will not be worked on

Comments

@wgresshoff
Copy link

With expressions it it currently possible to replace the values of existing annotations (there are only two). It would be great if it would be possible to add new ones, too. My use case is networking.istio.io/exportTo which adds support for the Istio ingress (don't know if it's the standard way, in our Kubernetes cluster it's done this way).

@Sgitario
Copy link
Contributor

Unfornately, this is not supported by YamlPath. This tool only supports replacement of values, not adding new values. So, you can't achieve this using configuration.
The good thing is that you can provide your custom Service resource with this annotation. See how you can do this: https://quarkus.io/guides/deploying-to-kubernetes#using-existing-resources

@Sgitario
Copy link
Contributor

I won't close this issue, but will add a label "won't fix".

@Sgitario Sgitario added the wontfix This will not be worked on label Jan 16, 2023
@wgresshoff
Copy link
Author

Thanks for your answer, I had that already done as workaround. Sorry to hear it's not possible, I think it would have been a valuable enhancement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants